Repository navigation
Add knip and drop the unused DEFAULT_BATCH_CONFIG export - #18
Conversation
knip.json skips the generated src/gen, treats scripts/*.mjs as entries since the Makefile runs them, and ignores @bufbuild/protoc-gen-es, which buf.gen.yaml loads as a local plugin. DEFAULT_BATCH_CONFIG is only used inside batch.ts and the package exports never exposed it, matching sdk-web where it was never exported.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Change: Other Merge Risk: ⚪ Minimal · up to The package entrypoint remains discoverable, and the removed export was not part of the exposed package API. The change is ready to merge after normal checks. Pre-merge checks |
|
knip.json skips the generated src/gen, treats scripts/*.mjs as entries since the Makefile runs them, and ignores @bufbuild/protoc-gen-es, which buf.gen.yaml loads as a local plugin. DEFAULT_BATCH_CONFIG is only used inside batch.ts and the package exports never exposed it, matching sdk-web where it was never exported.
Summary by CodeRabbit
DEFAULT_BATCH_CONFIGis no longer exported. Its default values are unchanged. The constant is no longer available to import directly.