Skip to content

Add knip and drop the unused DEFAULT_BATCH_CONFIG export - #18

Merged
poluruprvn merged 1 commit into
mainfrom
chore/add-knip
Oct 10, 2026
Merged

poluruprvn merged 1 commit into
mainfrom
chore/add-knip

Conversation

@poluruprvn

@poluruprvn poluruprvn commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

knip.json skips the generated src/gen, treats scripts/*.mjs as entries since the Makefile runs them, and ignores @bufbuild/protoc-gen-es, which buf.gen.yaml loads as a local plugin. DEFAULT_BATCH_CONFIG is only used inside batch.ts and the package exports never exposed it, matching sdk-web where it was never exported.

Summary by CodeRabbit

  • Chores
    • Added Knip configuration and a script for running dependency and code usage checks.
  • API Changes
    • DEFAULT_BATCH_CONFIG is no longer exported. Its default values are unchanged. The constant is no longer available to import directly.

knip.json skips the generated src/gen, treats scripts/*.mjs as entries since the Makefile runs them, and ignores @bufbuild/protoc-gen-es, which buf.gen.yaml loads as a local plugin. DEFAULT_BATCH_CONFIG is only used inside batch.ts and the package exports never exposed it, matching sdk-web where it was never exported.
@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 25037e86-7d6b-4e4c-8825-12550c330c26

📥 Commits

Reviewing files that changed from the base of the PR and between eb0b3f6 and b9e1897.


⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock

📒 Files selected for processing (3)
  • knip.json
  • package.json
  • src/batch.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

The pull request adds Knip configuration and a package command, and removes the export from DEFAULT_BATCH_CONFIG. Its default values remain unchanged.

Changes

Knip setup and export visibility

Layer / File(s) Summary
Configure and run Knip
knip.json, package.json
knip.json configures entry files, ignored generated source, and an ignored dependency. package.json adds Knip as a development dependency and adds a script to run it.
Change batch config export
src/batch.ts
DEFAULT_BATCH_CONFIG is no longer exported. Its default values remain unchanged.

Priority: ⬇️ Low

Change: Other

Merge Risk: ⚪ Minimal · up to b9e18

The package entrypoint remains discoverable, and the removed export was not part of the exposed package API. The change is ready to merge after normal checks.

Pre-merge checks | Passed 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes both main changes: adding Knip and removing the unused DEFAULT_BATCH_CONFIG export.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@poluruprvn
poluruprvn merged commit d1e8ac6 into main Oct 10, 2026
5 checks passed
@poluruprvn
poluruprvn deleted the chore/add-knip branch October 10, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant