Remove insecure default Django secret

pulp_file/tests/functional/api/test_domains.py

@@ -2,8 +2,8 @@
 import uuid
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.tests.functional.utils import download_file, generate_iso
 
 pytestmark = pytest.mark.skipif(not settings.DOMAIN_ENABLED, reason="Domains not enabled.")

pulp_file/tests/functional/api/test_filesystem_export.py

@@ -2,8 +2,8 @@
 import uuid
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore.exceptions import ApiException, BadRequestException
 from pulpcore.constants import TASK_STATES
 

pulp_file/tests/functional/api/test_pulp_export.py

@@ -3,8 +3,8 @@
 from pathlib import Path
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore.exceptions import ApiException, BadRequestException
 from pulpcore.constants import TASK_STATES
 

pulpcore/app/access_policy.py

@@ -1,9 +1,9 @@
 from copy import deepcopy
 
+from django.conf import settings
 from rest_access_policy import AccessPolicy
 from rest_framework.exceptions import APIException
 
-from pulpcore.app import settings
 from pulpcore.app.models import AccessPolicy as AccessPolicyModel
 from pulpcore.app.util import get_view_urlpattern, get_viewset_for_model
 

pulpcore/app/authentication.py

@@ -5,6 +5,7 @@
 from gettext import gettext as _
 
 import jq
+from django.conf import settings
 from django.contrib.auth import authenticate
 from django.contrib.auth.backends import RemoteUserBackend
 from rest_framework.authentication import (
@@ -16,8 +17,6 @@
 )
 from rest_framework.exceptions import AuthenticationFailed
 
-from pulpcore.app import settings
-
 _logger = logging.getLogger(__name__)
 
 

pulpcore/app/redis_connection.py

@@ -1,8 +1,7 @@
+from django.conf import settings
 from redis import Redis
 from redis.asyncio import Redis as aRedis
 
-from pulpcore.app.settings import settings
-
 _conn = None
 _a_conn = None
 

pulpcore/app/serializers/exporter.py

@@ -2,9 +2,10 @@
 import re
 from gettext import gettext as _
 
+from django.conf import settings
 from rest_framework import serializers
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DetailRelatedField,

pulpcore/app/serializers/importer.py

@@ -1,10 +1,11 @@
 import os
 from gettext import gettext as _
 
+from django.conf import settings
 from django.core.exceptions import ObjectDoesNotExist
 from rest_framework import serializers
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DomainUniqueValidator,

pulpcore/app/serializers/repository.py

@@ -2,10 +2,11 @@
 from gettext import gettext as _
 from urllib.parse import urlparse
 
+from django.conf import settings
 from rest_framework import fields, serializers
 from rest_framework_nested.serializers import NestedHyperlinkedModelSerializer
 
-from pulpcore.app import models, settings
+from pulpcore.app import models
 from pulpcore.app.serializers import (
     DetailIdentityField,
     DetailRelatedField,

pulpcore/app/settings.py

@@ -88,8 +88,8 @@
 # List of upload handler classes to be applied in order.
 FILE_UPLOAD_HANDLERS = ("pulpcore.app.files.HashingFileUploadHandler",)
 
-# SECURITY WARNING: this should be set to a unique, unpredictable value
-SECRET_KEY = "SECRET"
+# SECURITY WARNING: this must be set to a unique, unpredictable value.
+# SECRET_KEY = "SECRET"
 
 # Key used to encrypt fields in the database
 DB_ENCRYPTION_KEY = "/etc/pulp/certs/database_fields.symmetric.key"

pulpcore/app/views/importer.py

@@ -2,11 +2,11 @@
 import os
 from gettext import gettext as _
 
+from django.conf import settings
 from drf_spectacular.utils import extend_schema
 from rest_framework.response import Response
 from rest_framework.views import APIView
 
-from pulpcore.app import settings
 from pulpcore.app.serializers import PulpImportCheckResponseSerializer, PulpImportCheckSerializer
 
 

pulpcore/cache/cache.py

@@ -5,6 +5,7 @@
 
 from aiohttp.web import FileResponse, HTTPSuccessful, Request, Response, StreamResponse
 from aiohttp.web_exceptions import HTTPFound
+from django.conf import settings
 from django.http import FileResponse as ApiFileResponse
 from django.http import HttpResponse, HttpResponseRedirect
 from redis import ConnectionError
@@ -16,7 +17,6 @@
     get_async_redis_connection,
     get_redis_connection,
 )
-from pulpcore.app.settings import settings
 from pulpcore.metrics import artifacts_size_counter
 from pulpcore.responses import ArtifactResponse
 

pulpcore/tasking/kafka.py

@@ -6,7 +6,7 @@
 
 from django.conf import settings
 
-_bootstrap_servers = settings.get("KAFKA_BOOTSTRAP_SERVERS")
+_bootstrap_servers = getattr(settings, "KAFKA_BOOTSTRAP_SERVERS")
 
 
 if _bootstrap_servers is None:

pulpcore/tests/functional/api/test_auth.py

@@ -8,8 +8,7 @@
 from base64 import b64encode
 
 import pytest
-
-from pulpcore.app import settings
+from django.conf import settings
 
 
 @pytest.mark.parallel

pulpcore/tests/functional/api/test_tasking.py

@@ -9,8 +9,8 @@
 
 import pytest
 from aiohttp import BasicAuth
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulpcore import ApiException
 from pulpcore.constants import IMMEDIATE_TIMEOUT
 from pulpcore.tests.functional.utils import PulpTaskError, download_file

pulpcore/tests/functional/api/using_plugin/test_pulpimport.py

@@ -11,8 +11,8 @@
 from pathlib import Path
 
 import pytest
+from django.conf import settings
 
-from pulpcore.app import settings
 from pulpcore.client.pulp_file import FileRepositorySyncURL
 from pulpcore.client.pulpcore.exceptions import ApiException
 

pyproject.toml

@@ -289,6 +289,7 @@ extend-select = [
 [tool.ruff.lint.flake8-tidy-imports.banned-api]
 # This section is managed by the plugin template. Do not edit manually.
 "distutils".msg = "The 'distutils' module has been deprecated since Python 3.9."
+"pulpcore.app.settings".msg = "Always import 'settings' from 'django.conf' instead."
 
 [tool.ruff.lint.isort]
 # This section is managed by the plugin template. Do not edit manually.