Skip to content

fix: tests weren't honouring cross-platform paths #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieronlanning merged 2 commits into from
Aug 31, 2026
Merged

fix: tests weren't honouring cross-platform paths #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
890bf18
fix: tests weren't honouring cross-platform paths
kieronlanning Aug 31, 2026
f6fb8e5
Merge branch 'main' into init-release
kieronlanning Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions build/PipelineCLI/Settings/GitHubSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,18 @@ public sealed record GitHubSettings

public string ProductHeader { get; init; } = "Purview.SourceGeneratorFramework.Pipeline";

public string? GetGitHubToken() =>
!string.IsNullOrWhiteSpace(AccessToken) ? AccessToken
: !string.IsNullOrWhiteSpace(EnvAccessToken) ? EnvAccessToken
: null;
public string? GetGitHubToken()
{
if (!string.IsNullOrWhiteSpace(AccessToken))
return AccessToken;

if (!string.IsNullOrWhiteSpace(EnvAccessToken))
return EnvAccessToken;

// GitHub Actions provisions the automatic GITHUB_TOKEN as a plain environment variable.
// The config binder keys it under the "GitHub" section (GitHub:GITHUB_TOKEN), which the
// standard GITHUB_TOKEN env var does not map to, so read it directly as a fallback.
var processToken = Environment.GetEnvironmentVariable("GITHUB_TOKEN");
return string.IsNullOrWhiteSpace(processToken) ? null : processToken;
}
}
Loading