Skip to content

build: fix Pipeline pack #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieronlanning merged 1 commit into from
Sep 3, 2026
Merged

build: fix Pipeline pack #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions build/PipelineCLI/Modules/PackModule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,14 @@ namespace Purview.Telemetry.SourceGenerator.PipelineCLI.Modules;
[ModuleCategory("Build")]
[DependsOn<RunTestsModule>]
[DependsOn<VersionModule>]
public sealed class PackModule(IOptions<BuildSettings> settings, IOptions<ReleaseSettings> releaseSettings)
: Module<CommandResult>
public sealed class PackModule(IOptions<BuildSettings> settings) : Module<CommandResult>
{
protected override ModuleConfiguration Configure() =>
ModuleConfiguration
.Create()
.WithSkipWhen(_ =>
!settings.Value.RunPack || releaseSettings.Value.Mode == ReleaseMode.None
? SkipDecision.Skip(
"Packing is disabled. Set Build__RunPack=true and Release__Mode to something other than None to enable it."
)
!settings.Value.RunPack
? SkipDecision.Skip("Packing is disabled. Set Build__RunPack=true to enable it.")
: SkipDecision.DoNotSkip
)
.Build();
Expand Down
12 changes: 4 additions & 8 deletions src/src/SourceGenerator/SourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,13 @@
/>
<Compile Include="..\Shared\TelemetryAttributeNames.cs" Link="Shared\TelemetryAttributeNames.cs" />
</ItemGroup>
<!-- Package the build output into the "analyser" slot in the NuGet package -->
<!-- Package the build output into the "analyser" slot in the NuGet package.
The generator assembly itself is packed by the SDK (Purview.DotNetProjectSdk)
into analyzers/dotnet/cs; only the refactorings assembly is added here. -->
<ItemGroup>
<None Include="../../../assets/images/purview-logo.jpg" Pack="true" PackagePath="/Sdk/purview-logo.jpg" />
<None Include="../../../assets/images/purview-logo.jpg" Pack="true" PackagePath="/" />
<None Include="..\..\..\README.md" Pack="true" PackagePath="/Sdk/" />
<None Include="..\..\..\LICENSE.md" Pack="true" PackagePath="/Sdk/" />
<None
Include="$(OutputPath)\$(AssemblyName).dll"
Pack="true"
PackagePath="analyzers/dotnet/cs"
Visible="false"
/>
<None
Include="..\SourceGenerator.Refactorings\bin\$(Configuration)\netstandard2.0\Purview.Telemetry.SourceGenerator.Refactorings.dll"
Pack="true"
Expand Down