Repository navigation
fix: post a recording's summary to Slack only once - #112
Merged
Merged
Conversation
The summary's Slack post is stored as soon as it's posted, so a retry or a restart edits that post instead of posting a second one, and the transcript isn't uploaded again. Posting a message and completing a file upload are no longer retried after a timeout, only when Slack answered it did nothing. Closes #106
ChristopherPHolder
enabled auto-merge (squash)
October 30, 2026 23:37
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #106.
finishused to retry the whole pipeline (write, post, upload the transcript, store), so a failure after the post posted the summary again. A restart in that window did the same.RecordingStore.recordSummaryPoststores the Slack channel and timestamp as soon as the post is in Slack, using the existing columns, so no migration.summaryPostandunlinkedPostsonly see finished recordings, so edits and the startup permalink linker leave a post alone while it's still finishing.finishruns in three steps:finishRecording, the post update and any rewrite.chat.postMessageand completing a file upload are only retried when Slack answered that it did nothing (rate-limited or a 5xx). A timeout or dropped connection isn't retried, since the post may have gone through. Other calls keep their retries.finishRecordingfailing after the post still gives one post, one upload and one history row;docs/architecture.mdanddocs/recording.mddescribe the retry rule and the stored post.Trade-off: if posting times out, the summary isn't retried until the next restart picks up the unfinished recording. Retrying sooner could post it twice.
Checked
pnpm vp run -r typecheck,pnpm vp run checkandpnpm vp run -r testpass.effect-tsgo diagnosticsreports nothing for the bot, both libs and the Worker.