Repository navigation
refactor: give office time its own module - #132
Merged
Merged
Conversation
ChristopherPHolder
enabled auto-merge (squash)
October 31, 2026 11:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #127.
CONTEXT.mddefines office time, the office day and office hours, but the zone was inReminder, and office hours, the office day and the clock were inBanter. The Responder imported Banter for office hours, and the summary imported it for the clock.OfficeTimenow owns them:OFFICE_TIME_ZONEandinOfficeTime;isOfficeHours, renamed fromisBanterTimeto the wordCONTEXT.mduses, withOFFICE_HOURSreplacingBANTER_HOURS;startOfOfficeDay,startOfOfficeWeekandofficeClock.Banter, Reminder, the Responder and the summary use it. Banter keeps the banter periods, its log and its schedule. Nothing behaves differently.
This comes first in the folder split (#128 to #131), so answering and recording won't depend on announcing just to tell the time.
How I tested it
OfficeTime.test.ts. I added tests for the office day and week starting at midnight office time, Monday as the start of the week, and the clock.pnpm vp run cipasses.Checklist
vp run cipasses