Fix CVE-2025-45769 and unblock CI#50
Merged
Merged
Conversation
- Bump firebase/php-jwt from ^6.0 to ^7.0 to address CVE-2025-45769 (GHSA-2x45-7fc3-mxwq, CWE-326 inadequate encryption strength). v6.x accepts arbitrarily short HMAC keys; v7.0 enforces minimum key length and rejects weak secrets. - Bump doctrine/instantiator from 1.4.0 to ^1.5.0 to resolve a pre-existing dev dependency conflict that caused the prefer-lowest CI job to fail at dependency resolution before any tests could run. Closes #48. Co-authored-by: atymic <atymic@users.noreply.github.com>
The test secret key was 19 bytes, below the 32-byte minimum that firebase/php-jwt v7 enforces for HS256. Updated to a 32-byte key across all three test files. No logic changes.
phplint 5.4.0 (the prefer-lowest resolved version under ^4.0 || ^5.0) crashes with a fatal error on startup due to a missing symfony/options-resolver dependency. Fixed in 5.5.0. Narrowing to ^5.5 ensures prefer-lowest installs a working version.
phplint 5.5.0 requires php ^8.1, so ^5.5 broke PHP 8.0 CI jobs. ^4.5 || ^5.5 resolves 4.5.0 on PHP 8.0 and 5.5.0 on PHP 8.1 prefer-stable, avoiding all crashing versions (5.4.0) and PHP 8.1-only versions (5.4.2).
Keith-wright
force-pushed
the
fix/cve-2025-45769
branch
from
491d8e7 to
6fb0545
Compare
aonemd
approved these changes
Mar 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #48 — thank you to @atymic for the original contribution.