Repository navigation
ci: serialize core checks and scope release qualification - #41
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Contributor guidance still conflicts over whether race testing is mandatory.
1 open finding
What changed in this PR
This PR serializes CI checks and scopes release-only packaging validation to the exact-source release workflow.
Changes:
- Adds serialized normal and race test targets.
- Serializes hosted portability checks.
- Updates contributor and Windows verification guidance.
- Gates release packaging and WinGet validation appropriately.
| File | Summary |
|---|---|
Makefile |
Adds serialized standard and race test targets. |
docs/WINDOWS_VERIFICATION.md |
Documents revised source and release qualification boundaries. |
CONTRIBUTING.md |
Updates contributor validation and native qualification guidance. |
.github/workflows/ci.yml |
Serializes CI and scopes release-only checks. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| go generate ./internal/api | ||
| git diff --exit-code -- internal/api/api.gen.go | ||
| go test -race ./... | ||
| go test -p=1 -parallel=1 ./... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ordinary source CI uses normal Go unit/core checks with package/test concurrency one, followed by a one-worker hosted macOS/Windows x64/ARM64 matrix. Native keyring/console/shell/MCP and binary smoke remain automatic: Linux mocks cannot establish those OS contracts, the fixtures are synthetic/loopback and native ARM hardware is otherwise unavailable.
Published ZIP/provenance, installer lifecycle and WinGet validation remain mandatory in the existing exact-source release workflow-call profile. Their commands, candidate artifact names and release linkage are preserved. For related packaging changes, run local native qualification before PR submission and record SHA/environment/commands/results/skips. Broad race is local related-PR evidence via make test-race; no new manual/nightly workflow or quota added. Release calls have distinct cancellation groups.
Validation: full normal Go, vet, Formula renderer, actionlint/ShellCheck and diff passed locally. Actual hosted OS CI is required before merge. No local Windows, native keyring, installer, published download, login or notification test was performed; this change affects CI scheduling/profile selection, not those product implementations.