Repository navigation
feat: target the live pushman.io API with an independent endpoint login - #46
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Assert the exact production endpoint and coordinate the OpenAPI and public documentation updates before merging.
1 open issue
What changed in this PR
Prepares the CLI for migration to the api.pushman.io endpoint while preserving endpoint-scoped credentials.
Changes:
- Updates the default API endpoint.
- Documents the pending cutover and credential behavior.
- Adds mocked keyring isolation coverage.
| File | Summary |
|---|---|
README.md |
Documents the pending endpoint migration and credential behavior. |
internal/client/client.go |
Changes the default API URL; OpenAPI and public documentation require coordinated updates. |
cmd/pushman/main_test.go |
Tests endpoint-specific credentials; should assert the exact target endpoint. |
Review effort: Lite
WhiteKiwi
marked this pull request as ready for review
October 20, 2026 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Use https://api.pushman.io/v1 as the CLI source default after the live service cutover. Existing endpoint-scoped credentials stay separate: users log in at the new endpoint, and login/logout never copies or removes the prior endpoint login. Sync the reviewed public API snapshot and document the supported override for existing releases; client publication remains separate from this source merge.
Validation:
Public production documentation and API origin have shipped separately. Existing hosted OAuth connections need reconnection to the new resource; this CLI source change does not modify them or the installed iPhone app.
Final head6e7a6b6264754c00848f8a761eb6923fe68b53dc passed CI39516983887 (Linux, macOS, Windows x64/ARM native checks), Analyze Go39516983962, CodeQL and Graphite. WinGet manifest validation skipped under its existing condition. The canonical/public origin mismatch review is resolved; public production docs/bundle are already merged. No release/tag/workflow dispatch accompanies this source merge.