Repository navigation
feat: accept custom backends in set_async_backend - #439
Merged
tlambert03 merged 5 commits intoOct 6, 2026
Merged
Conversation
- public API now
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 99.76% 99.76%
=======================================
Files 23 23
Lines 2533 2548 +15
=======================================
+ Hits 2527 2542 +15
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tlambert03
reviewed
Oct 6, 2026
tlambert03
left a comment
Member
There was a problem hiding this comment.
thanks @jacopoabramo
I'm in favor of this, couple minor nits about what we expose. curious to get your thoughts
Contributor
Author
|
All reasonable. I'll address them asap |
Contributor
Author
|
@tlambert03 done. I've kept your original suggestion of |
Member
|
looks good thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437
AsyncBackendprotocol and export it frompsygnalalong withQueueItemAsyncBackendinstance inset_async_backendand return that same instanceRuntimeErrorwhen setting a custom backend while a different one is setclose()toTrioBackend, soclear_async_backendcloses every backend throughclose()EventLike.waitas returningobjectOne nitpick is that a
run()method needs to accesscallback.dereference()andWeakCallbackis private so maybe an helper method could shield the need to call it explicitly.