Repository navigation
Private imports, additions 16/19: the direct imports of Artifacts, Generic and Proof/Aes to Proof/Camellia - #2043
Merged
Merged
Conversation
…c and Proof/Aes to Proof/Camellia Output of `python3 ci/modularize.py visibility --additions-only` on Artifacts/Ed25519Verify Artifacts/Ed25519VerifyMessage Artifacts/TripleDesCbc Artifacts/TripleDesCfb Artifacts/TripleDesCfb8 Artifacts/TripleDesOfb Artifacts/X25519 Generic/AesGcm Generic/DsaArithmetic Generic/MdHash Proof/Aes/X86_64 Proof/AesGcm/X86_64 Proof/AesXts/X86_64 Proof/Bignum/AArch64 Proof/Camellia/AArch64 Proof/Camellia/Arm Proof/Camellia/X86, applied to main, but for the 8 files open pull requests change. Only adds imports of modules each file already sees. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TyNFiywMtzf7eAdKcGMA5z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the 16th additions PR of the private-imports series. #2013 has the plan and the tool, both now on main.
It only adds imports, using the output of
python3 ci/modularize.py visibility --additions-onlyon the directories below. It touches 315 files and adds 838 lines: 686import, 34public importand 118meta import. Nothing is removed.Each module gets a direct import of what it uses, or sees today, but would no longer see once its imports' imports turn private. It already sees each of these modules, so no module's visibility changes and no dependency is added.
Directories (under
lean/VerifiedGarbage/):Artifacts/{Ed25519Verify,Ed25519VerifyMessage,TripleDesCbc,TripleDesCfb,TripleDesCfb8,TripleDesOfb,X25519}Generic/{AesGcm,DsaArithmetic,MdHash}Proof/Aes/X86_64Proof/AesGcm/X86_64Proof/AesXts/X86_64Proof/Bignum/AArch64Proof/Camellia/{AArch64,Arm,X86}Left out on purpose: these 8 files are also changed by open PRs (#1866, #1971, #1975, #2003, #2005, #2006, #2029, #2041). Adding imports to them here would conflict with those PRs. Their additions go into the demotion PR for their directory, which adds any additions still missing, or into a small follow-up once those PRs merge.
Proof/Aes/X86_64/AesNi/BlocksProof/Aes/X86_64/VaesBlocks/BlocksProof/AesGcm/X86_64/Gather/CopyProof/AesGcm/X86_64/OneBlocks/FactsProof/AesXts/X86_64/Clmul87Proof/AesXts/X86_64/Vaes/TopProof/Bignum/AArch64/MontProof/Bignum/AArch64/MontMulNo file under
TCB/orSpec/changes.Regenerate it
After
lake buildof main 9dcda8e, runpython3 ci/modularize.py visibility --additions-onlyon the directories above, leaving out the 8 files listed. The result is applied to today's main, c6e4238.Checked locally
check_lean_modules.pypasses.check_lean_imports.pypasses.CI is the gate for the build.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TyNFiywMtzf7eAdKcGMA5z
Generated by Claude Code