Improve aggregation docstrings to improve searchability - #11471
Improve aggregation docstrings to improve searchability#11471SomeCoder23 wants to merge 4 commits into
Conversation
for more information, see https://pre-commit.ci
|
Hi @SomeCoder23 , thanks for the PR and the ping! It was great meeting you at the Scipy sprints :)
Actually, I'll try do this on airport internet :) |
|
Hi @SomeCoder23 . Running the aggregation file creates the updated docstring, but it does so without the examples (hence the -1000 line diff here). Would you be able to follow the instructions in the xarray/xarray/util/generate_aggregations.py Lines 1 to 16 in aae7fef (make sure to do Then I can give it a proper review |
|
Hey @VeckoTheGecko! I hope you are doing great! It was very nice meeting you as well :) |
|
All good! There's little expectation of timeliness or quick responses in open source anyway :) . Thanks for pushing the edits. I realised in review that actually our aggregations are out of date! #11488 I think whoever last made edits forgot to re-run the aggregation generation. I've put a couple pull requests up to deal with that. Once those are merged into main we can merge main into here and then I can give this a proper review without the other noise. |
Closes #7378
In
generate_aggregations.py@VeckoTheGecko