Rename LabeledRecipe.node to .recipe#279
Draft
liamhuber wants to merge 1 commit into
Draft
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
|
Because `LabeledRecipe` having a `label` and `node` is just ridiculous. It should clearly have a `label` and a `recipe`. Past-Liam didn't know what he was about. Signed-off-by: Liam Huber <liamhuber@greyhavensolutions.com>
liamhuber
force-pushed
the
labeled-recipe
branch
from
b0d8a56 to
281b054
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stdlib #279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 3105 3105
=========================================
Hits 3105 3105 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
LabeledRecipehaving alabelandnodeis just ridiculous. It should clearly have alabeland arecipe. Past-Liam didn't know what he was about.This is a compatibility-breaking change, since serialized recipes still have
"node":in this spot. We're v0, so I'm not going to worry about this.It becomes important to fix only if we introduce a stdlib, because then people will be invoking things like
fr.std.add.recipeand that's desirable vsfr.std.add.node, since it is ultimately returning a recipe object.