Skip to content

table: preserve decimal points with quad corrections disabled - #5204

Open
Don-Yin wants to merge 1 commit into
pymupdf:mainfrom
Don-Yin:fix-table-decimal-points-5198
Open

Don-Yin wants to merge 1 commit into
pymupdf:mainfrom
Don-Yin:fix-table-decimal-points-5198

Conversation

@Don-Yin

@Don-Yin Don-Yin commented Oct 23, 2026

Copy link
Copy Markdown

I reproduced the small table in #5198: with quad corrections disabled, 0.74 became '0 74\n.'. I saw this in default mode too: the existing '33043530\n, .' expectation became '330,435.30'.

I used extraction flags to get font-metric boxes for character grouping, without changing the global quad setting. I kept the existing accurate TextPage for layout. I added a rotated-table regression and corrected existing expectations that contained displaced punctuation. I left the separate extra-column issue unchanged.

I ran pytest tests: lite passed; the full distribution had only test_4392 failing, which also fails on unmodified main. The table suite passed with layout alone and with layout + 4llm.

Refs #5198.

Table extraction before and after the change

Signed-off-by: Don Yin <Don_Yin@outlook.com>
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Don-Yin

Don-Yin commented Oct 23, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant