Repository navigation
Fix keyword forwarding in single-process page extraction - #5206
Open
JackyHsu-X wants to merge 1 commit into
Open
JackyHsu-X wants to merge 1 commit into
JackyHsu-X wants to merge 1 commit into
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apply_pages(method="single")passesinitfn_kwargsto the page callback instead ofpagefn_kwargs. This can raise an unexpected-keyword error when an initializer has its own arguments, and it makes top-levelget_text()silently ignore options such asoption="dict",clip, andsort=True.Pass the documented
pagefn_kwargs, matching the multiprocessing path. Add real-PDF regressions for separate initializer/callback arguments and for extraction options in both single-process and multiprocessing modes, including non-contiguous page selection.Found through source inspection and reproduced locally. This is separate from the completed page-selection fix #4524 and the fork-page-index change in open #5076.
Validation on Windows / Python 3.13.15:
tests/test_textextract.py: 37 passed with the fix.The checkout's Python sources were tested using the native bindings from the official PyMuPDF 2.0 wheel (MuPDF 1.28.5). Native extensions were not rebuilt; the full repository suite and other platforms were not run.
AI assistance: OpenAI Codex investigated the defect, prepared the patch and regression tests, ran the checks, and self-reviewed the diff. No separate human code review is claimed.