Skip to content

Don't block PRs on linkcheck #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webknjaz merged 9 commits into from
May 3, 2026
+9 −2
Merged

Don't block PRs on linkcheck #2035

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3bfdecb
Don't block PRs on linkcheck
konstin Apr 20, 2026
3dcce68
Separate cancel group
konstin Apr 20, 2026
efca0b6
Remove unused github token from test.yml
konstin Apr 21, 2026
50f5435
Merge branch 'main' into konsti/linkcheck-on-main
konstin Apr 21, 2026
0f9103f
Review
konstin May 3, 2026
de82dfd
typo
konstin May 3, 2026
b5c65a8
Update .github/workflows/test.yml
konstin May 3, 2026
0cb3061
Restructure linkcheck matrix per review
konstin May 3, 2026
252680b
Merge branch 'main' into konsti/linkcheck-on-main
webknjaz May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,18 @@ jobs:
if: ${{ github.repository_owner == 'pypa' || github.event_name != 'schedule' }}
runs-on: ubuntu-latest
timeout-minutes: 20
continue-on-error: >-
${{ fromJSON(matrix.continue-on-error) }}
strategy:
matrix:
noxenv:
- build
- linkcheck
continue-on-error:
- false
include:
- noxenv: linkcheck
continue-on-error: >- # Don't block PRs on linkcheck unrelated failures
${{ toJSON(github.event_name == 'pull_request') }}

steps:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
Expand All @@ -50,7 +57,7 @@ jobs:
- name: Nox ${{ matrix.noxenv }}
env:
# Authenticate github.com requests during linkcheck to avoid rate limits.
GITHUB_TOKEN: ${{ github.token }}
GITHUB_TOKEN: ${{ matrix.noxenv == 'linkcheck' && github.token || '' }}
run: |
python -m nox -s ${{ matrix.noxenv }}

Expand Down