chore(tasks): remove dead tasks/check.py and its invoke wiring (closes #827)#1275
chore(tasks): remove dead tasks/check.py and its invoke wiring (closes #827)#1275r266-tech wants to merge 2 commits into
Conversation
Closes pypa#827. tasks/check.py is a ~10-year-dead invoke task: it imports the deprecated pkg_resources and calls PyPI XML-RPC methods removed years ago, so it fails on import (pypa#827). It is not run by CI or nox. Per @henryiii's removal recipe in pypa#1239, this also drops the now-orphaned wiring: tasks/__init__.py (only namespaced check), tasks/requirements.txt (invoke + progress, used only by check), the types-invoke pre-commit mypy dep, the progress.*/pkg_resources mypy import-ignore overrides, and the tasks/check.py ruff per-file-ignore. The remaining tasks/*.py are standalone scripts (stdlib + packaging.* only, no relative imports), so removing the package init does not affect them.
|
Okay to drop that |
|
Done — pushed a small CI follow-up in 0454857 that restores a minimal I left |
|
@r266-tech all your recent comments have initially been something like this before editing:
Github sends out the first comment via email, it doesn't wait to edit. Please fix this, it makes it difficult to follow progress from emails. |
|
Sorry about the email noise — that was a bug in my comment tooling. It was writing each reply to a temp file and the first POST sent the literal |
Closes #827. Picks up the "Simplifications" item from #1239.
tasks/check.pyis a ~10-year-deadinvoketask: it imports the deprecatedpkg_resourcesand calls PyPI XML-RPC methods that were removed years ago, so it fails on import (#827), and it is not run by CI or nox.Per @henryiii's removal recipe in #1239, this also drops the now-orphaned wiring:
tasks/__init__.py— only existed to namespacecheck(invoke.Collection(check))tasks/requirements.txt—invoke+progress, used only bycheck.pytypes-invokefrom the pre-commit mypyadditional_dependenciesprogress.*/pkg_resourcesentries from the mypy import-ignore override"tasks/check.py" = ["UP032"]ruff per-file-ignoreI verified repo-wide that
invoke,check.pep440,pkg_resources,progress, andtypes-invokeare referenced only by the deleted files. The remainingtasks/*.py(check_frozen_revs,licenses,paths,pickle_compat,select_pypi_*) are standalone scripts importing only stdlib +packaging.*with no relative imports, so removing the package__init__.pydoes not affect them (noxfile only callstasks/licenses.py).One note:
tasks/paths.py(definesCACHE) is now referenced only by the removedcheck.py. I left it in place to match the exact recipe, but happy to drop it too if you'd prefer.