Skip to content

Hook tracing crashes with specced Mock arguments and results #792

Open

Description

@Sandeep1519-droid

On main at 21c7e1672941a0cd9e3c555bf5e5007f1fbe3dc5 (Python 3.12.13), enabling hook tracing changes a successful hook call into a TypeError when an argument or first-result return value is a specced unittest.mock.Mock.

from unittest.mock import Mock
import pluggy

hookspec = pluggy.HookspecMarker("example")
hookimpl = pluggy.HookimplMarker("example")

class Spec:
    @hookspec(firstresult=True)
    def echo(self, value):
        """Return the value."""

class Plugin:
    @hookimpl
    def echo(self, value):
        return value

for spec in (str, dict):
    pm = pluggy.PluginManager("example")
    pm.add_hookspecs(Spec)
    pm.register(Plugin())
    value = Mock(spec=spec)
    assert pm.hook.echo(value=value) is value
    pm.trace.root.setwriter(print)
    pm.enable_tracing()
    try:
        assert pm.hook.echo(value=value) is value
    except TypeError as exc:
        print(spec.__name__, exc)

The string mock raises TypeError: object of type 'Mock' has no len() before the implementation runs. The dictionary mock raises TypeError: 'Mock' object is not iterable while tracing the result.

Mock(spec=...) reports its spec through __class__, so isinstance routes these objects into string formatting or dictionary metadata handling even though they are mocks. Tracing should log the mock without changing the hook result.

This report and a tested proposed fix were prepared with Codex.

Activity

  1. added a commit that references this issue on Oct 15, 2026
    eb0f67d
  2. DawnofGenX commented on Oct 15, 2026

    @DawnofGenX

    /take — reproduced on main 21c7e16: with tracing enabled, a specced Mock (spec=str / spec=dict) passed as a hook arg (or first result) raises TypeError from the tracing path before/instead of the implementation running. Planning a minimal fix in the hook-tracing formatting so spec'd mocks aren't routed through the str/dict special-casing.

  3. Sandeep1519-droid commented on Oct 16, 2026

    @Sandeep1519-droid
    Author

    Thanks for reproducing this, @DawnofGenX! There’s a proposed fix with regression tests in #793. Any feedback would be welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions