Repository navigation
Temporary registration via context manager - #784
Closed
victorwon2001 wants to merge 2 commits into
Closed
victorwon2001 wants to merge 2 commits into
victorwon2001 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
PluginManager.register_all(plugins)as a separate context manager for temporarily registering plugins. It registers each plugin in order, yields the same manager, and unregisters successful registrations in reverse order, both after normal use and on exceptions or later registration failures. Blocked registrations remain blocked, pre-existing registrations remain active, and the existingregister()signature andstr | Nonereturn value are unchanged. Historic hook implementations still replay saved calls as soon as they are registered; unregistering cannot undo those effects.Tests
Added regression coverage for single, multiple, and empty plugin iterables; temporary hook dispatch, reverse cleanup, body and registration errors, blocked and pre-existing plugins, nested contexts, and historic replay. All 231 tests and all pre-commit hooks (including Ruff and mypy) passed.
Fixes #52