Repository navigation
Fix hook tracing with specced mocks - #793
Open
Sandeep1519-droid wants to merge 3 commits into
Open
Sandeep1519-droid wants to merge 3 commits into
Sandeep1519-droid wants to merge 3 commits into
Conversation
Use the actual object type when selecting trace formatting so mocked strings and dictionaries do not interrupt hook execution. Co-authored-by: Codex <noreply@openai.com>
Both cases fail on upstream main and pass with the tracing fix. Co-authored-by: Codex <noreply@openai.com>
Fixes pytest-dev#792. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #792.
Enabling hook tracing currently makes otherwise successful calls fail when a hook receives
Mock(spec=str)or returnsMock(spec=dict)from a first-result hook. These mocks passisinstancechecks for their spec, but their methods do not behave like real strings or dictionaries.Choose formatting from the actual object type, preserving real subclasses and logging mocks normally.
Validation on Python 3.12.13:
uv run pytest— 221 passed with the fix.uv run pre-commit run -a— all hooks passed, including mypy.AI assistance: Codex prepared this fix and its tests at the contributor's request. This draft is awaiting the author's personal review before being marked ready.