fix(rewrite): short-circuit chained comparisons - #14822

Draft

RonnyPfannschmidt wants to merge 17 commits into

pytest-dev:mainfrom

RonnyPfannschmidt:ronny/fix-chained-compare-short-circuit

Commits on Aug 22, 2026

scripts: add an assert-rewrite diff tool
RonnyPfannschmidt
committed
be39f2f
fix(rewrite): prevent walrus operator double evaluation in assertions

committed
a39f739
Add changelog fragment for #14445

committed
5167153
test(rewrite): add xfail tests for remaining walrus edge cases

committed
b83ae76
fix(rewrite): avoid double evaluation of walrus in BoolOp condition

committed
8fe2b3a
fix(rewrite): assign walrus comparators to temps in chained comparisons

committed
c5c9443
fix(rewrite): show correct walrus values in BoolOp explanations

committed
555a1a2
refactor(rewrite): minimal snapshots in BoolOp for walrus conflicts

committed
d115f0e
fix(rewrite): freeze operands a later walrus would clobber
RonnyPfannschmidt
committed
5fe5987
fix(rewrite): freeze walrus and starred operands too
RonnyPfannschmidt
committed
242d582
refactor(rewrite): drop the walrus snapshot visit_Compare no longer needs

RonnyPfannschmidt
and
claude
committed
14cbbbf
refactor(rewrite): drop the unreachable Load guard in visit_Attribute

RonnyPfannschmidt
and
claude
committed
9967057
feat(rewrite): introspect container[key] in failure messages
RonnyPfannschmidt
committed
58e0526
feat(rewrite): introspect the condition of a ternary
RonnyPfannschmidt
committed
dfe9e00
feat(rewrite): show a method call on one line
RonnyPfannschmidt
committed
008a2f4
fix(rewrite): freeze operands against any later side effect (#14820)
RonnyPfannschmidt
committed
798a6d1
fix(rewrite): short-circuit chained comparisons (#14819)
RonnyPfannschmidt
committed
dcbec2d

Navigation Menu

Uh oh!

Uh oh!

fix(rewrite): short-circuit chained comparisons - #14822

fix(rewrite): short-circuit chained comparisons#14822
RonnyPfannschmidt wants to merge 17 commits into
pytest-dev:mainfrom
RonnyPfannschmidt:ronny/fix-chained-compare-short-circuit

Commits on Aug 22, 2026

scripts: add an assert-rewrite diff tool

fix(rewrite): prevent walrus operator double evaluation in assertions

Add changelog fragment for #14445

test(rewrite): add xfail tests for remaining walrus edge cases

fix(rewrite): avoid double evaluation of walrus in BoolOp condition

fix(rewrite): assign walrus comparators to temps in chained comparisons

fix(rewrite): show correct walrus values in BoolOp explanations

refactor(rewrite): minimal snapshots in BoolOp for walrus conflicts

fix(rewrite): freeze operands a later walrus would clobber

fix(rewrite): freeze walrus and starred operands too

refactor(rewrite): drop the walrus snapshot visit_Compare no longer needs

refactor(rewrite): drop the unreachable Load guard in visit_Attribute

feat(rewrite): introspect container[key] in failure messages

feat(rewrite): introspect the condition of a ternary

feat(rewrite): show a method call on one line

fix(rewrite): freeze operands against any later side effect (#14820)

fix(rewrite): short-circuit chained comparisons (#14819)