Show correct extra item in sequence comparison diffs - #14906
Open
SemTiOne wants to merge 8 commits into
Open
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
SemTiOne
marked this pull request as ready for review
August 19, 2026 06:30
Contributor
Author
|
Hi @Zac-HD, could you take a look at this PR when you have a moment? Thank you for your time. |
Added fallback test cases for extra items in lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest reported the wrong extra item when comparing sequences of different lengths. It printed the item past the end of the shorter side. The real extra item sat at the first differing index.
Before:
After:
The fix finds a single inserted item by checking whether the tails after the first differing index align, offset by one. It corrects only the single-extra-item case. Multi-item length differences still use the previous "first extra item" message.
Co-authored-bycommit trailers.changelogdirectory, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.AUTHORSin alphabetical order.