[ruff] Enable a dozen rules from ruff 0.16

pyproject.toml

@@ -147,7 +147,6 @@ lint.ignore = [
     "BLE001", # Do not catch blind exception
     # flake8-comprehensions ignore
     "C408", # Unnecessary `dict()`/`list()`/`tuple()` call (rewrite as a literal)
-    "C409", # Unnecessary list literal passed to `tuple()` (rewrite as a tuple literal)
     # pydocstyle ignore
     "D100", # Missing docstring in public module
     "D101", # Missing docstring in public class
@@ -170,19 +169,12 @@ lint.ignore = [
     # pytest can do weird low-level things, and we usually know
     # what we're doing when we use type(..) is ...
     "E721", # Do not compare types, use `isinstance()`
-    # flake8-future-annotations ignore
-    "FA102", # Missing `from __future__ import annotations`, but uses PEP 585/604 syntax
     # flynt ignore
     "FLY002", # Consider an f-string instead of string join
     # flake8-implicit-str-concat ignore
     "ISC004", # Unparenthesized implicit string concatenation in collection
     # flake8-logging ignore
-    "LOG009", # Use of undocumented `logging.WARN` constant
     "LOG015", # Call on root logger
-    # pep8-naming ignore
-    "N999", # Invalid module name
-    # pygrep-hooks ignore
-    "PGH005", # Mock method should be called
     # pylint ignore
     "PLC0105", # `TypeVar` name "E" does not reflect its covariance;
     "PLC0414", # Import alias does not rename original package
@@ -208,25 +200,20 @@ lint.ignore = [
     "PT031", # `pytest.warns()` block should contain a single simple statement
     # flake8-use-pathlib ignore
     "PTH124", # `py.path` is in maintenance mode, use `pathlib` instead
-    "PTH210", # Invalid suffix passed to `.with_suffix()`
     # ruff ignore
     "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
     "RUF061", # Use context-manager form of `pytest.raises()`
     # flake8-bandit ignore
     "S102", # Use of `exec` detected
     "S110", # `try`-`except`-`pass` detected, consider logging the exception
-    "S112", # `try`-`except`-`continue` detected, consider logging the exception
     # flake8-simplify ignore
     "SIM102", # Use a single `if` statement instead of nested `if` statements
     "SIM103", # Return the condition directly
     "SIM114", # Combine `if` branches using logical `or` operator
     "SIM115", # Use a context manager for opening files
     "SIM117", # Use a single `with` statement with multiple contexts instead of nested `with` statements
     "SIM201", # Use `!=` instead of `not ... == ...`
-    "SIM202", # Use `==` instead of `not ... != ...`
     "SIM211", # Use `not ...` instead of `False if ... else True`
-    "SIM222", # Use the simplified expression instead of `... or True`
-    "SIM223", # Use the simplified expression instead of `... and False`
     # tryceratops ignore
     "TRY002", # Create your own exception
     "TRY004", # Prefer `TypeError` exception for invalid type

src/_pytest/assertion/rewrite.py

@@ -723,7 +723,7 @@ def run(self, mod: ast.Module) -> None:
         while nodes:
             node = nodes.pop()
             if isinstance(node, ast.FunctionDef | ast.AsyncFunctionDef | ast.ClassDef):
-                self.scope = tuple((*self.scope, node))
+                self.scope = (*self.scope, node)
                 nodes.append(_SCOPE_END_MARKER)
             if node == _SCOPE_END_MARKER:
                 self.scope = self.scope[:-1]

src/_pytest/logging.py

@@ -85,7 +85,6 @@ class ColoredLevelFormatter(DatetimeFormatter):
         logging.CRITICAL: {"red"},
         logging.ERROR: {"red", "bold"},
         logging.WARNING: {"yellow"},
-        logging.WARN: {"yellow"},
         logging.INFO: {"green"},
         logging.DEBUG: {"purple"},
         logging.NOTSET: set(),

testing/python/approx.py

@@ -425,7 +425,7 @@ def test_mixed_sequence(self, assert_approx_raises_regex) -> None:
 
     def test_operator_overloading(self):
         assert 1 == approx(1, rel=1e-6, abs=1e-12)
-        assert not (1 != approx(1, rel=1e-6, abs=1e-12))
+        assert not (1 != approx(1, rel=1e-6, abs=1e-12))  # noqa: SIM202
         assert 10 != approx(1, rel=1e-6, abs=1e-12)
         assert not (10 == approx(1, rel=1e-6, abs=1e-12))
 

testing/python/fixtures.py

@@ -4541,7 +4541,7 @@ class TestParamValueKey:
     def test_equal_hashable_values(self) -> None:
         # Build equal-but-not-identical values to exercise the ``==`` path
         # rather than the identity shortcut.
-        v1, v2 = tuple([1, 2]), tuple([1, 2])
+        v1, v2 = tuple([1, 2]), tuple([1, 2])  # noqa: C409
         assert v1 is not v2
         k1, k2 = ParamValueKey(v1, 0), ParamValueKey(v2, 1)
         assert k1 == k2

testing/test_assertrewrite.py

@@ -676,7 +676,7 @@ def f11() -> None:
 
     def test_short_circuit_evaluation(self) -> None:
         def f1() -> None:
-            assert True or explode  # type: ignore[name-defined,unreachable] # noqa: F821
+            assert True or explode  # type: ignore[name-defined,unreachable] # noqa: F821,SIM222
 
         getmsg(f1, must_pass=True)
 
@@ -726,7 +726,7 @@ def f2() -> None:
 
     def test_boolop_percent(self) -> None:
         def f1() -> None:
-            assert 3 % 2 and False
+            assert 3 % 2 and False  # noqa: SIM223
 
         assert getmsg(f1) == "assert ((3 % 2) and False)"