Fix monkeypatch recording failed mutations - #14927
Open
dhootraghav wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
MonkeyPatchmethods recording undo state before the underlying mutation succeeds.Previously,
delattr,setitem, anddelitemrecorded their undo information before performing the mutation. If the mutation raised an exception, the failed operation was still recorded and later replayed byundo(), which could raise a second unexpected exception.This change records the undo state only after the mutation succeeds.
Changes
delattrundo state after successful deletion.setitemundo state after successful assignment.delitemundo state after successful deletion.Testing