Repository navigation
Conversation
akx
requested changes
Oct 26, 2026
akx
left a comment
akx
left a comment
Member
There was a problem hiding this comment.
Instead of using sys.intern, what about just having a temporary dict of these strings within the parser? That would work for free-threaded builds too.
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/po-message-id-sharing-20261018
branch
from
October 28, 2026 12:36
4e96885 to
4da5393
Compare
Author
|
Switched to a dict on the parser, dropped sys.intern and the build check, and cut the tests down to a single case in test_pofile_read.py. It only dedups within one read_po call now (e.g. the same msgid under different contexts), so separately loaded catalogs no longer share IDs. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading a PO file,
PoFileParsernow keeps a dict of message ID strings, so an msgid or plural part that appears again in the same file (for example under a different msgctxt) reuses the first string object instead of keeping a duplicate. The dict only lives as long as the parser, so nothing is held globally.Refs #571.