Added LRU caching of converted prompt-toolkit styles and colors.#1657
Added LRU caching of converted prompt-toolkit styles and colors.#1657kmvanbrunt merged 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1657 +/- ##
=======================================
Coverage 99.52% 99.52%
=======================================
Files 21 21
Lines 4810 4813 +3
=======================================
+ Hits 4787 4790 +3
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…kups instead of callbacks
tleonhardt
left a comment
There was a problem hiding this comment.
In general I love the couple places you added an @lru_cache and think that is a very smart idea.
However, I strongly prefer the callback approach in the couple places it was used versus the approach here. The callback approach never wastes any time calling any code to check if things changed when it doesn't need to. This approach here will still waste significant time checking when nothing has changed.
tleonhardt
left a comment
There was a problem hiding this comment.
Nice, I wasn't aware of Sytle.null()
No description provided.