Skip to content

Fix naturalsize() ValueError for custom formats containing text #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −1
Open

Fix naturalsize() ValueError for custom formats containing text #367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fec14ca
fix(filesize): don't parse formatted mantissa back to float
Sanjays2402 Jul 31, 2026
2577658
Address review feedback from @MohammedAlkindi: compare numeric mantis…
Sanjays2402 Sep 9, 2026
eb0b87b
Add regression test for %.0e binary-mode carry-over check
Sanjays2402 Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/humanize/filesize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,9 @@ def naturalsize(
# mantissa afterward; rounding can push it up to `base` (e.g. 999999 is
# 999.999 kB, which formats to "1000.0 kB"). When that happens and a larger
# suffix is available, step up one suffix so the result reads "1.0 MB".
if exp < len(suffix) and abs(float(format % (abs_bytes / (base**exp)))) >= base:
# `format` may contain text around the conversion, so compare the rendered
# mantissa with the rendered base instead of parsing it back to a float.
if exp < len(suffix) and format % (abs_bytes / (base**exp)) == format % base:
exp += 1
space = "" if gnu else " "
ret: str = format % (bytes_ / (base**exp)) + space + _(suffix[exp - 1])
Expand Down
4 changes: 4 additions & 0 deletions tests/test_filesize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@
([1024**2 - 1, True], "1.0 MiB"),
([1024**3 - 1, True], "1.0 GiB"),
([1024**2 - 1, False, True], "1.0M"),
# A custom format may contain text around the numeric conversion, which
# must not break the rounding carry-over check above.
([999999, False, True, "%.1f~"], "976.6~K"),
([999999, False, False, "%.1f~"], "1.0~ MB"),
],
)
def test_naturalsize(test_args: list[int] | list[int | bool], expected: str) -> None:
Expand Down