Repository navigation
Strengthen Settings equality properties - #1333
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthen
Settingsequality properties by replacing repeated comparisons with independently expected results for==and!=in both directions. Reuse the existing Hypothesis strategy to cover queued updates, acknowledgements and histories with equal current/final values but different intermediate proposals.Related to #466. This changes one test file.
Evidence
tox -e py310,py311,py312,py313,py314,lint,docspasses, including Ruff, mypy and the documentation build.Merge danger
Reversible test-only change. The assertions protect the existing behaviour that pending proposals are part of equality, even before acknowledgement.
Unverified
The
packagingandh2specenvironments, macOS, PyPy and other Windows Python versions were not run. The isolated Linux source snapshot excludes the bundled TLS certificate/key fixtures. Hosted CI and Codecov upload remain unverified.