Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecodedURL.replace(fragment=...)treats the supplied decoded fragment as an already-encoded URL fragment. Consequently, a literal fragment such as%41becomesA, and%FFraisesUnicodeDecodeError. Encode explicit fragment replacements using the same decoded-input rules already applied to the other URL components. Omittingfragmentretains its existing behavior.The base instead returns
"A"for the fragment. The patch adds regression and control tests, plus a changelog note.Validation
git diff --checkpassed. Mypy reports the same 16 diagnostics in unchanged Hypothesis files on base and patch.Validation ran on Python 3.9.25. Other Python versions and hosted CI remain unverified locally.
AI assistance was used to prepare the implementation and regression tests.