Repository navigation
Make the writer datetime test independent of local timezone - #32
saitakarcesme wants to merge 2 commits into
Conversation
|
Fixed the macOS CI blocker in a separate commit on this branch. The previous Mac tests run shows all three jobs cancelled with no runner assigned and no steps executed; each requested GitHub has retired that image and documents Validation: YAML parses and its only semantic difference is the runner label; The new Mac, Linux, Windows and static-analysis runs are now awaiting fork-workflow approval. Could a maintainer approve them, starting with the new Mac run? Fix and follow-up prepared with Codex assistance. |
Fixes #6.
test_writer_bad_messagecallstimestamp()on a naive datetime, so its expected bytes depend on the host timezone. The two hard-coded timestamps only cover some environments; adding another timestamp as in the closed #7 would leave the underlying problem.Use a UTC-aware
JsonDatetimeand keep a single timestamp expectation (1546304461), while retaining the existing empty-output allowance for the standard JSON fallback. Instantiate the subclass directly instead of permanently replacing the globaldatetime.datetimeclass.Validation on Python 3.13.5:
datetime.datetimeretains its original identity after each suite run.git diff --checkpass.This changes tests and macOS CI only; it does not alter production serialization or the separate orjson migration in #29. No Windows/OpenBSD run was performed locally.
CI follow-up:
macos-13runner and were cancelled without executing any steps.macos-15-intel, preserving the x64 architecture and Python 3.8/3.9/3.10 matrix.git diff --checkpasses, and all 27 tests pass on Linux / Python 3.13.15 withTZ=Europe/Luxembourg. GitHub macOS execution is still required.AI disclosure: prepared and tested by OpenAI Codex acting on behalf of @saitakarcesme. No independent human review is claimed.