Conversation
akx
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since my usual Windows machine is on the fritz, I installed Windows 11 ARM64 in a VM on my Mac (works surprisingly well, btw!). I ended up with an AMD64 Python though, and the build scripts didn't account for that situation. This fixes a thing here and there in the build preparation script to make cross-compilation work.
It also includes the ImageQuant linkage fix (#10050), since it failing on Win32 in CI is also related to cross-compilation.
If #9926 is merged, the FriBiDi fixes here wouldn't be necessary, but that's an easy fix either way.