Move typing imports under TYPE_CHECKING block - #9827
Open
hugovk wants to merge 3 commits into
Open
Conversation
akx
reviewed
Jul 28, 2026
| factor_y = int((box[3] - box[1]) / size[1] / reducing_gap) or 1 | ||
| if factor_x > 1 or factor_y > 1: | ||
| reduce_box = self._get_safe_box(size, cast(Resampling, resample), box) | ||
| reduce_box = self._get_safe_box(size, cast("Resampling", resample), box) |
Contributor
There was a problem hiding this comment.
Did this get changed just for consistency? (Resampling is defined in this file.)
Member
Author
There was a problem hiding this comment.
It was done by TC006: https://docs.astral.sh/ruff/rules/runtime-cast-value/
Contributor
There was a problem hiding this comment.
Check. That wasn't clear from the commit/PR message. I didn't scroll down far enough to see that all of TC got enabled :)
Member
Author
There was a problem hiding this comment.
We could ignore TC006, skip it for this line, or leave it be. I don't mind really.
radarhere
reviewed
Jul 29, 2026
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use https://docs.astral.sh/ruff/rules/#flake8-type-checking-tc so we only import typing things when checking types.