Prevent negative ImageStat variance - #9994
Merged
Merged
Conversation
Member
|
I've found that the floating point error can be fixed by using integers. See lllleolin-max#2 |
radarhere
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On affected platforms, a constant white image of size
(919, 405)can produce a slightly negativeImageStat.Stat.vardue to floating-point rounding, causingstddevto raise a math domain error.Current implementation (updated 2026-09-14):
Adopted @radarhere's suggestions from lllleolin-max#2, preserving all three original commits through e5203ab.
sumandsum2as integers and use integer exponentiation, avoiding the rounding in this regression instead of clamping the result afterwards. Their return annotations are nowlist[int]; variance remains floating-point.var == [0.0].Validation of this revision:
selftest.py: 59 passed.Local validation used Windows/Python 3.12.11 with this checkout's ImageStat and ImageEnhance modules and Pillow 12.3.0 prebuilt native extensions and remaining modules. Native extensions were not rebuilt; the full test suite was not run locally. This does not claim all floating-point variance rounding is eliminated. New upstream CI is pending completion.
Prepared with AI assistance; the adopted implementation and test simplification are @radarhere's original commits.