Fix progress bar remaining time calculation - #544
Open
lprnmns wants to merge 2 commits into
Open
Conversation
lprnmns
marked this pull request as ready for review
August 31, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The custom ProgressBar remaining-time placeholder always reports less than one second after progress begins. For a bar with 10 total steps, 2 completed steps, and 10 seconds elapsed, it reports "< 1 sec" even though 40 seconds remain.
Fix
Use the number of uncompleted steps when estimating the remaining time. This makes remaining equal to estimated completion time minus elapsed time.
Tests
poetry run pytest tests/ui/test_progress_bar.py -k remaining- passed (1 passed, 25 deselected)poetry run pytest- passed (248 passed, 3 skipped)poetry run pre-commit run --all-files- passedpoetry run mypy- passedtowncrier check --compare-with origin/main- passedCompatibility
This changes only the documented custom remaining-time calculation. The normal and verbose built-in formats do not use the remaining placeholder.
Related issue
Independent reproduction; no matching open issue or pull request was found.
The required
news/544.bugfix.mdfragment is included.