Fix page titles and the klink sidebar logo - #153
Merged
timkpaine merged 1 commit intoSep 8, 2026
Conversation
The <title> tag was built from html_title, which carried a styled <code> element for the version. Themes deriving from the basic layout rendered that markup escaped into browser tabs, so keep html_title plain text. Sphinx only assigns a document title when a page opens with a single top level section, so a README leading with a logo or badges left the root page titled "<no title>". Fall back to the configured project title. Klink's theme.conf points at _static/logo.png by default and yardang ships no such file, leaving a broken image in its sidebar. Search coverage now follows BUNDLED_THEMES so a newly added theme cannot silently miss it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 86.19% 86.19%
=======================================
Files 16 16
Lines 2021 2021
Branches 209 209
=======================================
Hits 1742 1742
Misses 217 217
Partials 62 62 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The <title> tag was built from html_title, which carried a styled
element for the version. Themes deriving from the basic layout rendered that markup escaped into browser tabs, so keep html_title plain text.Sphinx only assigns a document title when a page opens with a single top level section, so a README leading with a logo or badges left the root page titled "". Fall back to the configured project title.
Klink's theme.conf points at _static/logo.png by default and yardang ships no such file, leaving a broken image in its sidebar.
Search coverage now follows BUNDLED_THEMES so a newly added theme cannot silently miss it.