Fix rejected handshake cleanup in threading server#1729
Closed
Sanjays2402 wants to merge 1 commit into
Closed
Conversation
Return explicitly when a process hook rejects the opening handshake instead of relying on an assertion that is swallowed or removed under optimization. Fixes python-websockets#1722.
Member
|
Duplicate of #1726. |
Member
|
I prefer the approach to testing from #1726; it's more straightforward and consistent with pre-existing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threading server treated an intentional HTTP rejection as a successful handshake and relied on an assertion to stop before the connection handler. That assertion was swallowed in normal mode and removed under
python -O, where the handler ran on a closed connection.This returns explicitly for a rejected handshake, closes and joins the receive thread, and adds a regression check that detects the internal assertion. Fixes #1722.