Copy type-feature from issue to PR - #710
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #710 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 2149 2173 +24
Branches 97 100 +3
=========================================
+ Hits 2149 2173 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
StanFromIreland
left a comment
There was a problem hiding this comment.
The current change looks correct to me.
Two points, however, that I'd like to highlight on the general design:
- Removing the label isn't recorded. I fear this may come up in practice, e.g. possibly in the case of docs issues (which are sometimes labelled as
type-feature), but it's avoidable by also removing it from the issue, so it's not a major issue. - It doesn't sync on updates to the issue. So if the
type-featurelabel is added to an issue after the PR is opened, it won't automatically be propagated, unless the PR itself is also updated. This means it could be missed before a merge.
Neither of these are too troublesome or likely to come up in practice, so I think we can try the current (simpler) implementation, and revisit if the issues pop up in practice. In any case, please post an announcement after deploying as it's likely to cause some confusion, especially considering the "two weeks" since this was originally discussed.
|
Thanks for the review! Yes, agree to start simple, and can iterate if needed. I'll merge this and verify it works on an issue/PR, then post on the DPO thread. |
|
Verified on issue python/cpython#158270 -> PR python/cpython#158271. Announced at https://discuss.python.org/t/workflow-change-coming-mandatory-reviews-on-new-features/68135/17. |
Phase two of Workflow change coming: mandatory reviews on new features:
Two weeks is a long time in open source :)