gh-152409: Save the trace --file counts when --no-report is used - #152410
Open
tonghuaroot wants to merge 2 commits into
Open
gh-152409: Save the trace --file counts when --no-report is used#152410tonghuaroot wants to merge 2 commits into
tonghuaroot wants to merge 2 commits into
Conversation
The counts were only persisted at the end of CoverageResults.write_results(), which main() skips when --no-report is given, so --no-report --file silently discarded them. Move that step into CoverageResults.save_counts() (still called from write_results()) and call it on the --no-report branch too.
|
|
||
| self.save_counts() | ||
|
|
||
| def save_counts(self): |
Member
There was a problem hiding this comment.
This becomes an undocumented public method of the documented public class.
Make it private.
Member
There was a problem hiding this comment.
Alternatively, you can keep it public and document (with versionadded).
serhiy-storchaka
added
needs backport to 3.13
Contributor
Author
|
Done in 19c6975: renamed to |
serhiy-storchaka
approved these changes
Aug 18, 2026
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, be we need an approve of @zooko, @gvanrossum, or @smontanaro which participiated in the original discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m trace --count --no-report --file FILEnow saves the counts toFILE, so counts can be accumulated over several runs — which is what--fileand--no-reportare documented to support.The counts were pickled only at the end of
CoverageResults.write_results(), whichmain()skips when--no-reportis given, so
--no-report --filesilently discarded them. This extractsthat step into
CoverageResults.save_counts()(still called fromwrite_results()exactly as before) and also calls it on the--no-reportbranch.save_counts()only writes when--filewas given (it is a no-opotherwise), and a
--filerun without--no-reportalready wrote thefile for every mode, so the two paths are now consistent.