Skip to content

gh-156099: Fix a crash when deleting SSLContext.keylog_filename #156103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-storchaka wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −0
Open

gh-156099: Fix a crash when deleting SSLContext.keylog_filename #156103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6684b6d
gh-156099: Fix a crash when deleting SSLContext.keylog_filename
serhiy-storchaka Aug 20, 2026
628f256
Check that a failed deletion does not change the value
serhiy-storchaka Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5518,6 +5518,12 @@ def test_keylog_defaults(self):
with self.assertRaises(TypeError):
ctx.keylog_filename = 1

ctx.keylog_filename = os_helper.TESTFN
with self.assertRaisesRegex(AttributeError, 'cannot be deleted'):
del ctx.keylog_filename
# a failed deletion does not change the value
self.assertEqual(ctx.keylog_filename, os_helper.TESTFN)

def test_keylog_filename(self):
self.addCleanup(os_helper.unlink, os_helper.TESTFN)
client_context, server_context, hostname = testing_context()
Expand Down
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2026-08-20-12-00-00.gh-issue-156099.Kp4vRt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a crash when deleting the ``keylog_filename`` attribute of
:class:`ssl.SSLContext`.
It now raises :exc:`AttributeError`.
6 changes: 6 additions & 0 deletions Modules/_ssl/debughelpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ static int
_PySSLContext_set_keylog_filename(PyObject *op, PyObject *arg,
void *Py_UNUSED(closure))
{
if (arg == NULL) {
PyErr_Format(PyExc_AttributeError,
"attribute 'keylog_filename' of '%.100s' objects "
"cannot be deleted", Py_TYPE(op)->tp_name);
return -1;
}
#if defined(MS_WINDOWS_APP) && !defined(MS_WINDOWS_DESKTOP)
PyErr_SetString(PyExc_NotImplementedError,
"set_keylog_filename: unavailable on UWP build");
Expand Down
Loading