gh-156100: Fix crashes in the sqlite3 Connection.autocommit setter - #156104
Open
serhiy-storchaka wants to merge 3 commits into
Open
gh-156100: Fix crashes in the sqlite3 Connection.autocommit setter#156104serhiy-storchaka wants to merge 3 commits into
serhiy-storchaka wants to merge 3 commits into
Conversation
The setter passed the deleted value to autocommit_converter(), which dereferences it.
serhiy-storchaka
added
needs backport to 3.13
LEGACY_TRANSACTION_CONTROL is -1, the same value which PyLong_AsLong() returns on error, so the converter reported success with OverflowError set.
serhiy-storchaka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setter passed the deleted value to
autocommit_converter(), which dereferences it inPy_IsTrue().Deleting the attribute now raises
AttributeError, likerow_factoryandtext_factory(gh-149738).autocommit_converter()also reported success withOverflowErrorset when the value was an integer which does not fit in Clong, becausePyLong_AsLong()returns -1 on error, andLEGACY_TRANSACTION_CONTROLis -1.Such value is now rejected with
ValueError, like any other invalid value.