gh-156101: Fix sqlite3 Cursor.arraysize on a failed assignment - #156105
Open
serhiy-storchaka wants to merge 3 commits into
Open
gh-156101: Fix sqlite3 Cursor.arraysize on a failed assignment#156105serhiy-storchaka wants to merge 3 commits into
serhiy-storchaka wants to merge 3 commits into
Conversation
PyLong_AsUInt32() stores 0 in the target on error, so the attribute was clobbered when the assigned value was too large.
serhiy-storchaka
added
needs backport to 3.14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyLong_AsUInt32()stores 0 in the target on error, so assigning a too large value leftarraysizeset to 0.The value is now converted into a local variable first, as in 3.13.