Skip to content

gh-156115: Use the simulator deployment-target flag for iOS simulator builds #156116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clementperon wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −4
Open

gh-156115: Use the simulator deployment-target flag for iOS simulator builds #156116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Build/2026-08-20-14-02-33.gh-issue-156115.KXr8wU.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
iOS simulator builds are now configured with
``-mios-simulator-version-min`` instead of the device's
``-mios-version-min``. The device flag made the linker reject libraries
resolved from the simulator SDK, so library detection silently failed.
11 changes: 9 additions & 2 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,8 +1008,13 @@ AS_CASE([$host],
dnl Add the compiler flag for the iOS minimum supported OS version.
AS_CASE([$ac_sys_system],
[iOS], [
AS_VAR_APPEND([CFLAGS], [" -mios-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
AS_VAR_APPEND([LDFLAGS], [" -mios-version-min=${IPHONEOS_DEPLOYMENT_TARGET}"])
dnl -mios-version-min names the device platform; against the simulator SDK it
dnl makes the linker reject every dylib it resolves there.
Comment on lines +1011 to +1012

@freakboy3742 freakboy3742 Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to encode the historical existence of a bug in a comment.

Suggested change
dnl -mios-version-min names the device platform; against the simulator SDK it
dnl makes the linker reject every dylib it resolves there.

AS_IF([test "x$_host_device" = "xsimulator"],
[_ios_version_min_flag=-mios-simulator-version-min],
[_ios_version_min_flag=-mios-version-min])
AS_VAR_APPEND([CFLAGS], [" ${_ios_version_min_flag}=${IPHONEOS_DEPLOYMENT_TARGET}"])
AS_VAR_APPEND([LDFLAGS], [" ${_ios_version_min_flag}=${IPHONEOS_DEPLOYMENT_TARGET}"])
Comment on lines +1013 to +1017

@freakboy3742 freakboy3742 Aug 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be significantly simplified (and be less reliant on the mostly incidental side effect of _host_device being set hundreds of lines earlier) by using a single case statement that evaluates on a match for the host, has 2 cases, with each case setting CFLAGS and LDFLAGS.

],
)

Expand Down
Loading