test :- Add more PyType C API tests - #158669
Closed
Amankumar-10012004 wants to merge 1 commit into
Closed
Amankumar-10012004 wants to merge 1 commit into
Amankumar-10012004 wants to merge 1 commit into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Add tests on functions: * PyType_GenericAlloc() * PyType_SUPPORTS_WEAKREFS()
Amankumar-10012004
force-pushed
the
add-pytype-tests
branch
from
October 3, 2026 17:48
7b54f1e to
3345d8c
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
Since Victor has noted he is working on this, I'm sorry but I'm going to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing tests for several
PyTypeC‑API functions that were identified in issue #155503. The new tests verify the behavior of:PyType_GenericAllocPyType_SUPPORTS_WEAKREFSAll added tests pass on Windows and Linux using the CPython test suite.
Motivation
The original issue highlighted that the following functions were not exercised by the existing test suite:
PyType_ClearCachePyType_GetFlagsPyType_IsSubtypePyType_ReadyPyType_GenericAllocPyType_SUPPORTS_WEAKREFSFour of these were already covered by previous patches. This PR completes the coverage by adding tests for the remaining two functions, ensuring that future changes to these APIs are caught by the test harness.
Changes
Modules/_testcapi/type.ctype_supports_weakrefswrapper and registration intest_methods[].Modules/_testlimitedcapi/type.ctype_genericallocwrapper and registration intest_methods[].Lib/test/test_capi/test_type.pytest_type_genericallocandtest_type_supports_weakrefsmethods to theTypeTestsclass.Testing
Build CPython from the repository: