Do not call best_matches() unless we show the message#21307
Open
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Open
Do not call best_matches() unless we show the message#21307ilevkivskyi wants to merge 1 commit intopython:masterfrom
ilevkivskyi wants to merge 1 commit intopython:masterfrom
Conversation
hauntsaninja
approved these changes
Apr 24, 2026
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks! I'd mentioned this in one of the PRs, but guess the change wasn't made to the other PRs
Collaborator
|
Also great that you're looking at profiles on homeassistant, thanks for doing that |
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is very slow. While playing with parallel checking for home-assistant/core I found that we spend ~30% in this function (compiled, 12 workers).