Preserve TypedDict annotations on Python 3.14 - #77
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65.
On Python 3.14, class-based TypedDict annotations are deferred, so reading only the class namespace loses the declared fields. Reading inherited annotations from
base.__dict__also misses annotations stored by the type descriptor. Useannotationlib.get_annotations(..., FORWARDREF)on 3.14 and retrieve base annotations through attribute access, preserving the older-Python path and the existing functional/keyword syntaxes.The regression tests cover local types, inheritance, invalid annotations, quoted and deferred self references, and future annotations. Add 3.14 to the test matrix and tox environments.
Validation: the existing inheritance test and three added regressions fail on the unchanged implementation under Python 3.14. With the fix,
python -We -m unittest discover testspasses all 17 tests on Python 3.14.6; Python 3.13 passes 16 with the 3.14-only test skipped. Flake8 andgit diff --checkpass.AI disclosure: this patch, tests, and description were prepared with OpenAI Codex; the commands above were executed locally.