Automatically add CODEOWNERS as collaborators#49
Closed
StanFromIreland wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Closed accidentally? But I don't see a button to re-open. |
Collaborator
|
Uh, strange. I also don't see a button to reopen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Following the plan set out by the issue. It gets a little complicated however, as there may be occasions where there is more then one PR open against
main(this patch ignores all but the first), or when the PR is open against a branch other than main (I ignored the others as occasionally people open backports, but there may be scenarios where the vulnerability only affects certain branches).Rather than dealing with the CODEOWNERS I found a PyPI package,
codeowners, which can do it for us. It also conveniently splits users and teams.It's not ideal IMO, but, we can always iterate.
It'll also be a good idea to explain and announce this somewhere, maybe the Devguide, as it may be a surprise for CODEOWNERS unfamiliar with the PSRT/GHSAs.