Skip to content

Enhance artifact upload/download in sync workflow - #307

Merged
rffontenelle merged 4 commits into
mainfrom
update-artifact-path
Sep 5, 2026
Merged

Enhance artifact upload/download in sync workflow#307
rffontenelle merged 4 commits into
mainfrom
update-artifact-path

Conversation

@rffontenelle

@rffontenelle rffontenelle commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

potodo,md and stats.json were not being updated in the current CI, and that's unintentional. When splitting commit job from sync (translations pull) job, upload-artifact and download-artifact GitHub actions were incorrectly configured:

  • upload-artifact action by default warns when no input file is found, and but we want to it to be an error (that shouldn't happen in our scenario).
  • upload-artifact action doesn't include hidden files by default, and we need to include the file from hidden directory .tx/config
  • upload-artifact action's input files had incorrect path: they are stored inside $PYDOC_LANG_DIR, not in the $GITHUB_WORKSPACE, so the path needed to be specified.
  • upload-artifact doesn't keep $PYDOC_LANG_DIR when compressing the input fies, which means in download-artifact needs a 'path' value to be specified in order to extract to the correct directory.

@rffontenelle rffontenelle changed the title Update artifact paths in sync.yml for PYDOC_LANG_DIR Enhance artifact upload/download in sync workflow Sep 5, 2026
@rffontenelle
rffontenelle merged commit 0687fc0 into main Sep 5, 2026
26 checks passed
@rffontenelle
rffontenelle deleted the update-artifact-path branch September 5, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant