Repository navigation
Migrate to plausible - #3177
Migrate to plausible#3177JacobCoffee wants to merge 6 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e7cd52483
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| style="max-width:{{ sponsorship.sponsor.web_logo|ideal_size:dimension }}px;height:auto;width:auto;" | ||
| ></div> | ||
| {% with logo_width=sponsorship.sponsor.web_logo|ideal_size:dimension %} | ||
| <a href="{{ sponsorship.sponsor.landing_page_url }}" rel="sponsored noopener" target="_blank" class="plausible-event-name=Sponsor+Click plausible-event-sponsor={{ sponsorship.sponsor.slug }}" style="border-bottom: 0;"> |
There was a problem hiding this comment.
When an enabled sponsor has no landing page, this always emits an anchor with href="" (or href="None" for database NULLs), so clicking the logo reloads the sponsors page in a new tab or navigates to a nonexistent relative URL while recording a misleading Sponsor Click. This is a supported input: Sponsor.landing_page_url is nullable/blank, the application form marks it optional, and test_forms.py explicitly creates a sponsor with an empty value. Only wrap the logo in the tracked anchor when a landing URL exists.
Useful? React with 👍 / 👎.
c67637a to
e1e8541
Compare
Closes #3176