Skip to content

conformance: allow consistent treatment of kwargs: Unpack[TD] #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carljm wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Open

conformance: allow consistent treatment of kwargs: Unpack[TD] #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion conformance/results/ty/callables_kwargs.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ conformance_automated = "Fail"
conformant = "Unsupported"
errors_diff = """
Line 46: Expected 1 errors
Line 51: Expected 1 errors
Line 58: Expected 1 errors
Line 63: Expected 1 errors
Line 65: Expected 1 errors
Expand Down
2 changes: 1 addition & 1 deletion conformance/tests/callables_kwargs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def func3() -> None:

td2 = TD2(v1=2, v3="4")
func1(**td2) # OK
func1(v1=1, v2="", v3="5", v4=5) # E: v4 is not in TD2
func1(v1=1, v2="", v3="5", v4=5) # E?: v4 is not in TD2, but could be in a subtype
func1(1, "", "5") # E: args not passed by position

# > Passing a dictionary of type dict[str, object] as a **kwargs argument
Expand Down