feat(ipad): universal app + responsive layout + App Store screenshots - #25
Merged
Conversation
- Make the app a proper iPad app: set TARGETED_DEVICE_FAMILY=1,2 on all app build configs (was unset → ran letterboxed in iPhone-compat mode on iPad, which is what App Review saw). - Responsive layout: cap content to a centered MAX_CONTENT_WIDTH column on large screens (Home / Editor / Preview) so it reads well full-screen on iPad instead of stretching edge-to-edge. - Fastlane deliver setup for App Store screenshots (Fastfile lanes `screenshots`/`metadata` using an ASC API key, SCREENSHOTS.md guide, .gitignore for the .p8). Screenshots committed under ios/fastlane/screenshots/en-US (iPhone 6.9" + iPad 13", 3 screens each). - Copy: "right on your phone" → "your device" (shown on iPad too). Note: requires a new EAS build — build 44 was iPhone-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
scripts/upload-screenshots.sh sources the (gitignored) ASC key ids from ios/fastlane/.asc.env and runs `fastlane screenshots`, so uploading the App Store screenshots next time is a single command. The .p8 and .asc.env stay gitignored. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TARGETED_DEVICE_FAMILY=1,2on all app configs. It was unset, so the app ran letterboxed in iPhone-compatibility mode on iPad (what App Review saw). Now full-screen native on iPad.MAX_CONTENT_WIDTHcolumn on large screens (Home / Editor / Preview) so it reads well on iPad instead of stretching edge-to-edge. No change on iPhone.deliversetup for App Store screenshots:screenshots/metadatalanes using an ASC API key,SCREENSHOTS.mdguide,.gitignorefor the.p8.ios/fastlane/screenshots/en-US/— iPhone 6.9″ + iPad 13″, 3 screens each (home / editor / preview).Build 44 was iPhone-only (built before the device-family change). To ship the universal iPad app, rebuild + resubmit after merge.
Verification
tsc,eslint(0 warnings),jest🤖 Generated with Claude Code